refactor: Remove secret usage from Vault PKI implementation for CA CSR #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielArndt
force-pushed
the
no-secrets-pki-ca-csr
branch
from
5f790b6 to
757df7b
Compare
gruyaume
requested changes
Jul 22, 2024
|
@gruyaume yeah, sorry, I added it to the Jira ticket but forgot to move it here. |
gruyaume
approved these changes
Jul 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the solution for: #415
Currently, we store the CSR in a secret so that we can compare the certificate that is returned with the one we sent. However, we already store this CSR in the relation databag, and we are only ever requesting a single certificate.
Removing the dependence on secrets will simplify the solution for #415 because we won’t need to consider as many cases in the event that adding or updating the secret fails. Furthermore, it simplifies our code.
Checklist: